Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added openspeedtest #834

Merged
merged 5 commits into from
Jan 21, 2023
Merged

added openspeedtest #834

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97c48a8
added openspeedtest
Svelte-Enthusiast Jan 10, 2023
8d6a900
changed default version to speedtest
Svelte-Enthusiast Jan 10, 2023
1908c2d
suggested fixes
Svelte-Enthusiast Jan 19, 2023
f992276
add formatting
Svelte-Enthusiast Jan 19, 2023
9756446
fixed replacement issues
Svelte-Enthusiast Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions public/v4/apps/openspeedtest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@ captainVersion: 4

services:
'$$cap_appname':
image: index.docker.io/openspeedtest/latest:$$cap_openspeedtest_version
image: index.docker.io/test/latest:$$cap_test_version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of wrong replacement here. All "openspeedtest" instances in the definition are converted to test

caproverExtra:
containerHttpPort: '3001'
restart: always

caproverOneClickApp:
variables:
- id: '$$cap_openspeedtest_version'
label: OpenSpeedTest Version
- id: '$$cap_test_version'
label: Test Version
defaultValue: 'speedtest'
description: Check out their Docker page for the valid tags https://hub.docker.com/r/openspeedtest/latest/tags
description: Check out their Docker page for the valid tags https://hub.docker.com/r/test/latest/tags
instructions:
start: |-
OpenSpeedTest is a self-hosted speedtest. You can read more about this on https://openspeedtest.com/selfhosted-speedtest.
Test is a self-hosted speedtest. You can read more about this on https://test.com/selfhosted-speedtest.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here... Test is a self-hosted speedtest. You can read more about this on https://test.com/selfhosted-speedtest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super weird. the only thing i did was run the formatter. i fixed it with the next push

end: |-
OpenSpeedTest has been successfully deployed! You must enable https for the app to work. Go to the app setting and enable https.
displayName: OpenSpeedTest
Test has been successfully deployed! You must enable https for the app to work. Go to the app setting and enable https.
displayName: Test
isOfficial: true
description: |-
OpenSpeedTest is a self-hosted network speedtest written in vanilla Javascript.
Test is a self-hosted network speedtest written in vanilla Javascript.