Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SystemStackError when running deploy:migrate #247

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

mattbrictson
Copy link
Member

The :migration_command setting added in 1.6.0 was self-referential, causing an infinite loop and a SystemStackError. Fix by removing the lambda declaration that caused this loop.

Fixes #246

@mattbrictson mattbrictson added the 🐛 Bug Fix Fixes a bug label Jul 12, 2020
@capistrano-bot
Copy link

Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes.

Generated by 🚫 Danger

@mattbrictson mattbrictson merged commit c2f84da into master Jul 12, 2020
@mattbrictson mattbrictson deleted the bugs/stack-overflow-on-migrate branch July 12, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task deploy:migrate exists with SystemStackError (version 1.6.0)
2 participants