Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad ReferencedItems cards. #198

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Pad ReferencedItems cards. #198

merged 7 commits into from
Nov 8, 2024

Conversation

markpbaggett
Copy link
Member

What does this do?

This is a tiny change to ensure MDX.Cards in ReferencedItems have padding and a similar layout to how Masonry Cards are done.

What type of change is this?

  • 🐛 Bug fix (non-breaking change addressing an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • 🧨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🚧 Maintenance or refinement of codebase structure (ex: dependency updates)
  • 📘 Documentation update

Additional Notes

I recognize that there is a want to move away from Stitches, but I wasn't sure the correct pattern to use now. Happy to talk about this here and do it the new way. I'm demoing something for donors next week and would love to pull this padding from upstream rather than maintain in my fork regardless of how code needs to look.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
canopy-iiif ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:38pm

@markpbaggett
Copy link
Member Author

Before:

Screenshot 2024-11-08 at 12 29 19 PM

After:

Screenshot 2024-11-08 at 12 28 23 PM

Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me. Being a little particular here as we should make sure that the MDX is prefixed.

markpbaggett and others added 4 commits November 8, 2024 13:19
Co-authored-by: mat <mat@northwestern.edu>
Co-authored-by: mat <mat@northwestern.edu>
Co-authored-by: mat <mat@northwestern.edu>
Co-authored-by: mat <mat@northwestern.edu>
@markpbaggett
Copy link
Member Author

@mathewjordan last commit attempts to fix #199

@markpbaggett markpbaggett merged commit bc569f0 into main Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants