-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pad ReferencedItems cards. #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathewjordan
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and makes sense to me. Being a little particular here as we should make sure that the MDX is prefixed.
Co-authored-by: mat <mat@northwestern.edu>
Co-authored-by: mat <mat@northwestern.edu>
Co-authored-by: mat <mat@northwestern.edu>
Co-authored-by: mat <mat@northwestern.edu>
@mathewjordan last commit attempts to fix #199 |
mathewjordan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This is a tiny change to ensure
MDX.Cards
inReferencedItems
have padding and a similar layout to how Masonry Cards are done.What type of change is this?
Additional Notes
I recognize that there is a want to move away from Stitches, but I wasn't sure the correct pattern to use now. Happy to talk about this here and do it the new way. I'm demoing something for donors next week and would love to pull this padding from upstream rather than maintain in my fork regardless of how code needs to look.