Oracular update for apt-hook

[dheyay]

Why is this needed?

This PR solves all of our problems because it correctly formats apt news and apt messages for oracular.

Fixes: LP #2086753

Test Steps

---

• (un)check this to re-run the checklist action

[github-actions]

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

• Launchpad: #2086753

Confirm

• I've properly referenced all bugs that this PR fixes

How to properly reference fixed bugs

• If this PR is related to a Jira item, include an SC-1234 reference in the PR title
• If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
• If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

• I have updated or added any unit tests accordingly
• No unit test changes are necessary for this change

Integration Tests

• I have updated or added any integration tests accordingly
• No integration test changes are necessary for this change

Documentation

• Changes here need to be documented and I have referenced the docs PR in the description
• No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

• Yes, and I have requested those reviews via GitHub
• No

[orndorffgrant]

Sorry for the very long delay.

[dheyay]

Updated @orndorffgrant

[lucasmoura]

@dheyay I know that you are adding a test for APT news, but I wonder if we should add an orocular integration test for the json-hook changes

[dheyay]

@dheyay I know that you are adding a test for APT news, but I wonder if we should add an orocular integration test for the json-hook changes

@lucasmoura I would say we can probably do without a dedicated test since the updated test acts like a dedicated oracular test for the json-hook. It checks the formatting for the apt-news message as well as the summary for the number of packages.

Let me know if that works, I would not mind adding a short test to check for formatting of updates/packages as well.

[dheyay]

Updated with the test @lucasmoura @orndorffgrant

[orndorffgrant]

Please run the hook unit tests: make -C apt-hook test (Github CI is failing on package builds because the build runs those tests).

Also:

• I've properly referenced all bugs that this PR fixes

is not accurate since the comment displays "None" under "Bug references". Please reference the LP bug in a commit in the format "LP: #12345678" (No "Fixes").

Also please clean up the commits in the PR. These can probably all be squashed into one.

[orndorffgrant]

I'm still running all the affected integration tests, but noticed two things.

[orndorffgrant]

Thanks!

@julian-klode Can you also do a quick review of this?

This PR shows reformatted pro messages and APT News to fit with the new APT UX on oracular onward. It determines what style to show by the release in /etc/os-release.

I know that ideally the style would be determined by APT telling the hook what style it is using via jsonrpc params, but we'd like to get something basic done in our v35 release in February.

[julian-klode]

This looks good. It might be worth thinking about realigning

"%d standard security updates"

to

"Standard security updates: %d"

to match the new summary format ordering ("X upgraded" became "Upgrading: X").

[julian-klode]

You can now also query for plucky onward the binary::apt::APT::Output-Version option in the options array that's part of the hello handshake.

It is an integer (possibly stored in a string), 30 is the new format (it's essentially major*10+minor.

And quiet is an integer of 1 for quieter, or 2 for "no output".

[renanrodrigo]

@dheyay Thanks much for your work. As @julian-klode says in plucky we get to read the option, it's better if we fix it for plucky onward. I will take this PR when v35 is released and this will be part of the next release.