Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plugin build error message #809

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmatsuoka
Copy link
Contributor

Update craft-parts to obtain the combined output in case of a
plugin build error. This results in better information on the causes
of the failure.

Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com

  • Have you signed the CLA?

@cmatsuoka
Copy link
Contributor Author

Test execution seems wrong, why is it exiting right after printing this message?

2025-02-10T14:02:51.4183853Z :: Looking for a Python interpreter called "python3.10" in the payload...
2025-02-10T14:02:51.4185078Z :: ++ find /root/parts/my-part/install/usr/bin /root/stage/usr/bin -type f -executable -name python3.10 -print -quit
2025-02-10T14:02:51.4186339Z :: + payload_python=
2025-02-10T14:02:51.4186952Z :: + '[' -n '' ']'
2025-02-10T14:02:51.4187644Z :: + echo 'Python interpreter not found in payload.'
2025-02-10T14:02:51.4188463Z :: Python interpreter not found in payload.
2025-02-10T14:02:51.4189305Z Failed to run the build script for part 'my-part'.
2025-02-10T14:02:51.4190114Z Detailed information: 
2025-02-10T14:02:51.4190663Z :: + '[' -n '' ']'
2025-02-10T14:02:51.4191386Z :: + echo 'Python interpreter not found in payload.'
2025-02-10T14:02:51.4192329Z :: Python interpreter not found in payload.
2025-02-10T14:02:51.4193501Z Recommended resolution: Check the build output and verify the project can work with the 'python' plugin.
2025-02-10T14:02:51.4196700Z For more information, check out: https://documentation.ubuntu.com/rockcraft/en/latest/reference/plugins.html
2025-02-10T14:02:51.4197743Z Failed to execute rockcraft in instance.

@cmatsuoka cmatsuoka force-pushed the craft-4070-test-combined-error-presentation branch 2 times, most recently from 49b4e43 to 239b7cd Compare February 10, 2025 14:50
@cmatsuoka cmatsuoka closed this Feb 10, 2025
@cmatsuoka cmatsuoka reopened this Feb 10, 2025
@cmatsuoka cmatsuoka closed this Feb 10, 2025
@cmatsuoka cmatsuoka reopened this Feb 10, 2025
@cmatsuoka cmatsuoka force-pushed the craft-4070-test-combined-error-presentation branch 2 times, most recently from b15ff9b to 239b7cd Compare February 10, 2025 22:48
Update craft-parts to obtain the combined output in case of plugin
build error. This results in better information on the causes of
the failure.

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@cmatsuoka cmatsuoka force-pushed the craft-4070-test-combined-error-presentation branch from 239b7cd to 6b3507f Compare February 11, 2025 00:14
@cmatsuoka cmatsuoka closed this Feb 11, 2025
@cmatsuoka cmatsuoka reopened this Feb 11, 2025
@cmatsuoka
Copy link
Contributor Author

Any issues don't seem to be reproducible if only the Python plugin tests are running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant