Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pin tenacity to <8.4 #469

Closed
wants to merge 1 commit into from

Conversation

tonyandrewmeyer
Copy link
Contributor

Issue

Unit tests fail with tenacity 8.4.

Solution

Pin tenacity to < 8.4. I assume you'll want to figure out how to use 8.4 and adjust the tests appropriately, but for now this makes relocking work.

Fixes #468.

@dimaqq
Copy link

dimaqq commented Jun 25, 2024

Same comment as here: canonical/mysql-k8s-operator#443 (comment)

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.54%. Comparing base (e7c1809) to head (eebc7f8).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   66.25%   66.54%   +0.28%     
==========================================
  Files          17       18       +1     
  Lines        3180     3871     +691     
  Branches      424      537     +113     
==========================================
+ Hits         2107     2576     +469     
- Misses        935     1109     +174     
- Partials      138      186      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlcsaposs-canonical
Copy link
Contributor

closing since canonical/operator#1272 fixed (canonical/mysql-k8s-operator#442 (comment))

will address when updating tenacity in poetry.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tenacity >= 8.4 breaks unit tests
3 participants