Avoid using incompatible juju debug-log options in test helper

[shayancanonical]

Issue

$ juju debug-log --model=test-upgrade-rollback-incompat-pz5a --level=WARNING --lines=100 --no-tail
ERROR setting --no-tail and --lines not valid

Solution

Avoid using juju debug-log --lines --no-tail. Replace --lines with --limit

[paulomach]

Safer to test juju version (we still test 2.9)

[shayancanonical]

@paulomach i think the --limit option exists in juju 2.9 as well:

shayanp@brisbane:~$ juju switch test
uk8s-2-9-51:admin/test (no change)
shayanp@brisbane:~$ juju2.9 version 
2.9.52-ubuntu-amd64
shayanp@brisbane:~$ juju2.9 debug-log --model=test --level=WARNING --lines=100 --no-tail
shayanp@brisbane:~$ juju2.9 debug-log --model=test --level=WARNING --limit=100 --no-tail
shayanp@brisbane:~$ juju2.9 debug-log --model=test --level=INFO --limit=100 --no-tail
controller-0: 19:09:49 INFO juju.worker.apicaller [6706bc] "controller-0" successfully connected to "localhost:17070"
controller-0: 19:09:49 INFO juju.worker.logforwarder config change - log forwarding not enabled
controller-0: 19:09:49 INFO juju.worker.logger logger worker started
controller-0: 19:09:49 INFO juju.worker.pruner.action status history config: max age: 336h0m0s, max collection size 5120M for test (6706bccb-ed60-4b48-8e56-14bd716b9e13)
controller-0: 19:09:49 INFO juju.worker.pruner.statushistory status history config: max age: 336h0m0s, max collection size 5120M for test (6706bccb-ed60-4b48-8e56-14bd716b9e13)
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:51 INFO juju.worker.caasupgrader abort check blocked until version event received
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:51 INFO juju.worker.caasupgrader unblocking abort check
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:52 INFO juju.worker.muxhttpserver starting http server on 0.0.0.0:17071
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:52 INFO juju.worker.caasadmission ensuring model k8s webhook configurations
shayanp@brisbane:~$ juju2.9 debug-log --model=test --level=INFO --lines=100 --no-tail
controller-0: 19:09:49 INFO juju.worker.apicaller [6706bc] "controller-0" successfully connected to "localhost:17070"
controller-0: 19:09:49 INFO juju.worker.logforwarder config change - log forwarding not enabled
controller-0: 19:09:49 INFO juju.worker.logger logger worker started
controller-0: 19:09:49 INFO juju.worker.pruner.action status history config: max age: 336h0m0s, max collection size 5120M for test (6706bccb-ed60-4b48-8e56-14bd716b9e13)
controller-0: 19:09:49 INFO juju.worker.pruner.statushistory status history config: max age: 336h0m0s, max collection size 5120M for test (6706bccb-ed60-4b48-8e56-14bd716b9e13)
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:51 INFO juju.worker.caasupgrader abort check blocked until version event received
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:51 INFO juju.worker.caasupgrader unblocking abort check
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:52 INFO juju.worker.muxhttpserver starting http server on 0.0.0.0:17071
model-6706bccb-ed60-4b48-8e56-14bd716b9e13: 19:09:52 INFO juju.worker.caasadmission ensuring model k8s webhook configurations

[sinclert-canonical]

Same concerns as in this comment.