Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update backup file docs #149

Merged
merged 3 commits into from
Apr 30, 2024
Merged

docs: update backup file docs #149

merged 3 commits into from
Apr 30, 2024

Conversation

yanksyoon
Copy link
Member

Applicable spec: N/A

Overview

Update backup guide to be copy-pasteable & fix some bugs with pathing.

Rationale

:)

Juju Events Changes

Module Changes

Library Changes

Checklist

@yanksyoon yanksyoon requested a review from a team as a code owner April 30, 2024 07:27
arturo-seijas
arturo-seijas previously approved these changes Apr 30, 2024
jdkandersson
jdkandersson previously approved these changes Apr 30, 2024
Thanhphan1147
Thanhphan1147 previously approved these changes Apr 30, 2024
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yanksyoon
Copy link
Member Author

Fixed issues w/ lint from the previous PR that I didn't catch locally after running tox -e unit.

Copy link
Contributor

Test coverage for ccd13ec

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/actions.py         30      0      4      0   100%
src/agent.py          123      0     20      0   100%
src/auth_proxy.py      53      0      8      0   100%
src/charm.py           89      0     14      0   100%
src/cos.py             21      0      0      0   100%
src/ingress.py         17      0      4      0   100%
src/jenkins.py        375      0     60      0   100%
src/pebble.py          25      0      2      0   100%
src/state.py          110      0     24      0   100%
src/timerange.py       31      0      6      0   100%
---------------------------------------------------------------
TOTAL                 874      0    142      0   100%

Static code analysis report

Run started:2024-04-30 09:27:44.660952

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 7485
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yanksyoon yanksyoon merged commit 4e019f7 into main Apr 30, 2024
29 checks passed
@yanksyoon yanksyoon deleted the docs/backup branch April 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants