Allow vacuum on main #734
Open
Allow vacuum on main #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 74.02% 81.14% +7.11%
==========================================
Files 192 196 +4
Lines 27899 29648 +1749
Branches 2802 4100 +1298
==========================================
+ Hits 20653 24057 +3404
+ Misses 4914 3916 -998
+ Partials 2332 1675 -657 ☔ View full report in Codecov by Sentry. |
The amalgamation does not support LIMIT on delete.
|
While I don't like a lot the implementation (the parsing of vacuum) this would fix #530. |
marco6
force-pushed
the
allow-vacuum-on-main
branch
from
3501316 to
d9ee242
Compare
|
The implementation seems now better after the call with @just-now. I'm marking this as ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in these days on MM, VACUUM seems to be a transactional operation.
While it is true that it needs to attach a temporary database, new pages are then copied in the WAL and, as such, the attachment of the temporary file does not violate the VFS assumption about WAL and main file being unique after every statement.
This PR changes the implementation from one that allows 0 attached database (through
sqlite3_limit) to one using an authorizer to allow only temporary files to be attached.