Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: update description #165

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

rebornplusplus
Copy link
Member

@rebornplusplus rebornplusplus commented Oct 16, 2024

Resolves #164.

Updates the snap description. Uses the output from chisel help --all instead of chisel --help for details. Removes the usage from snap description.

@cjdcordeiro cjdcordeiro added the Simple Nice for a quick look on a minute or two label Oct 17, 2024
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the question of whether we want to change the description of the commands or add more information. In my opinion, that can wait until next cycle where we will have a focus on documentation. For now it seems like an easy win to update the snap to contain the same information that the CLI has.

Thanks Rafid for this UX improvements!

@linostar linostar self-requested a review October 23, 2024 12:57
@letFunny letFunny added the Polish Refactorings, etc label Nov 8, 2024
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@niemeyer niemeyer merged commit a09dd15 into canonical:main Nov 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Polish Refactorings, etc Simple Nice for a quick look on a minute or two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: update Chisel snap description
5 participants