fix: Fixed issues caused by cleaning up .NET objects. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the JavaScript and .NET objects in sync causes more overhead and management that just trigging a delete during a .NET object finalize call. Because the .NET object can go out of scope, for some reason or another, it could cause the JavaScript reference to be lost, when the cache is cleared. To make this library as easy as possible to use without having to micro manage the state of all objects created/destroyed, it will just hold onto the cache for the life of the browser page request. The automatic cache remove was reverted, the 'removeEntity' interop is still available for custom code to be easily created. General Styles and Cleanup needed after adding .editorconfig.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-plant-0f8750a10-28.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-plant-0f8750a10-28.centralus.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the JavaScript and .NET objects in sync causes more overhead and management that just trigging a delete during a .NET object finalize call.
Because the .NET object can go out of scope, for some reason or another, it could cause the JavaScript reference to be lost, when the cache is cleared.
To make this library as easy as possible to use without having to micro manage the state of all objects created/destroyed, it will just hold onto the cache for the life of the browser page request.
The automatic cache remove was reverted, the 'removeEntity' interop is still available for custom code to be easily created.
General Styles and Cleanup needed after adding .editorconfig.