Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/update deepseek model #1714

Open
wants to merge 1 commit into
base: test/add_models_tests
Choose a base branch
from

Conversation

Rkejji
Copy link
Collaborator

@Rkejji Rkejji commented Mar 4, 2025

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and poetry.lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@Rkejji Rkejji requested a review from Wendong-Fan March 4, 2025 20:03
@Rkejji Rkejji changed the base branch from master to test/add_models_tests March 4, 2025 20:04
)
assert (
# Check that the reasoning message is parsed
# TODO findout how to make this assertion work
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wendong-Fan could you help me with this ? When I try to compare the response with the expected result it doesn't work. It is due to the fact that the response is a MagicMock therefor it returns a class rather than a string. I open if you see another way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant