Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ChatAgent #1424
refactor: ChatAgent #1424
Changes from 33 commits
e36211f
a533339
c0e6a01
e04368d
47f2c40
22ce90a
80f6587
7544b5c
ffe13c9
2e0cf7c
036092b
b397824
2ce8758
40007c8
f6e4041
b9eb5be
00d1bf0
5cd8eca
e8c8148
520c29a
8faf857
2c96e48
995bbb3
859216b
72ff026
ccbaee0
52744b9
0c28cf1
03e494b
5667bb4
720cec2
03fc264
255ae77
d001a10
c0e43c1
567bc05
1ab516a
08935d0
6bc08b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this function used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet used, they are supposed to be used by models that does not natively support tool callings, but we havent added support for them yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the argument is
self
and do we use it anywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used, refer to: #1621
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this from inside ChatAgent and forgot to remove this. I will update this one in the follow up PRs