Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynacmic graph via neo4j #1254

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

NeilJohnson0930
Copy link
Collaborator

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@NeilJohnson0930 NeilJohnson0930 linked an issue Nov 30, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Nov 30, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 17 milestone Nov 30, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NeilJohnson0930 NeilJohnson0930 changed the title feat: support dynacmic graph via nebula feat: support dynacmic graph via neo4j Jan 24, 2025
@NeilJohnson0930 NeilJohnson0930 modified the milestones: Sprint 17, Sprint 21 Jan 24, 2025
Copy link
Collaborator

@keli-wen keli-wen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the deduplication utils related content, but I might be missing some environment configurations related to running the notebook (such as neo4j, etc.), so I suggest you pull it down and rerun it once to ensure that my updates have no errors ✨.

@NeilJohnson0930
Copy link
Collaborator Author

Got it, thx @keli-wen

@NeilJohnson0930 NeilJohnson0930 requested review from raywhoelse and Wendong-Fan and removed request for raywhoelse and Wendong-Fan February 15, 2025 14:14
Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:45Z
----------------------------------------------------------------

for the title could we highlight the finance use case a little bit?


NeilJohnson0930 commented on 2025-02-19T12:26:27Z
----------------------------------------------------------------

Dynamic Knowledge Graph Construction for Financial Report with CAMEL

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:46Z
----------------------------------------------------------------

use camel's latest version, don't install [all], only install necessary dependency like [rag]


NeilJohnson0930 commented on 2025-02-19T12:27:27Z
----------------------------------------------------------------

pip install "camel-ai[rag]==0.2.22"

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:47Z
----------------------------------------------------------------

the api key setting part is different with other cookbooks, refer to https://colab.research.google.com/drive/17SiWWjoK7l8Sy9FBsGKUHC6zuEsLt2yX?usp=sharing


NeilJohnson0930 commented on 2025-02-25T03:21:59Z
----------------------------------------------------------------

API key setting has been changed to require user input via getpass

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:47Z
----------------------------------------------------------------

no need to print this


NeilJohnson0930 commented on 2025-02-25T03:22:43Z
----------------------------------------------------------------

Removed

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:48Z
----------------------------------------------------------------

Line #27.    # Set up Mistral Large 2 model

no need to use mistral model in this cookbook, could we use together ai instead? since we can also announce this cookbook with them https://www.together.ai/


NeilJohnson0930 commented on 2025-02-25T03:24:58Z
----------------------------------------------------------------

Latest cookbook has been updated to replace the Mistral model with the Together model.

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:49Z
----------------------------------------------------------------

Line #46.        model_type=ModelType.GPT_3_5_TURBO,

why here is gpt 35 turbo, I think use gpt 4o mini would be more suitable, since o1 would make high cost and slow


NeilJohnson0930 commented on 2025-02-25T03:26:22Z
----------------------------------------------------------------

GPT-4o Mini model has been set

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:49Z
----------------------------------------------------------------

this code chunk is too big and including different parts, could we splite it to smaller code chunk and add more description to make it more easy to read?


NeilJohnson0930 commented on 2025-02-25T03:30:02Z
----------------------------------------------------------------

Thanks for the suggestion! I've broken the code into smaller chunks and added more descriptions to enhance readability. Let me know if you have any further feedback!

Copy link

review-notebook-app bot commented Feb 19, 2025

View / edit / reply to this conversation on ReviewNB

Wendong-Fan commented on 2025-02-19T09:59:50Z
----------------------------------------------------------------

"access results by navigating to http://localhost:7474 in your web browser" is the guide for local deploy, for user using neo4j cloud, we also need to provide link to cloud db


NeilJohnson0930 commented on 2025-02-25T03:35:29Z
----------------------------------------------------------------

Thanks for the feedback! I've updated the guide to generate the graph in Neo4j Aura for cloud deployment and included screenshots/GIFs to showcase the graph. However, since enterprise account features are not supported at the moment, sharing a direct graph link will be delayed.

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NeilJohnson0930 and @keli-wen , left some comments for both the feature and cookbook

Copy link
Collaborator Author

Dynamic Knowledge Graph Construction for Financial Report with CAMEL


View entire conversation on ReviewNB

Copy link
Collaborator Author

pip install "camel-ai[rag]==0.2.22"


View entire conversation on ReviewNB

Copy link
Collaborator Author

API key setting has been changed to require user input via getpass


View entire conversation on ReviewNB

Copy link
Collaborator Author

Removed


View entire conversation on ReviewNB

Copy link
Collaborator Author

Latest cookbook has been updated to replace the Mistral model with the Together model.


View entire conversation on ReviewNB

Copy link
Collaborator Author

GPT-4o Mini model has been set


View entire conversation on ReviewNB

Copy link
Collaborator Author

Thanks for the suggestion! I've broken the code into smaller chunks and added more descriptions to enhance readability. Let me know if you have any further feedback!


View entire conversation on ReviewNB

Copy link
Collaborator Author

Thanks for the feedback! I've updated the guide to generate the graph in Neo4j Aura for cloud deployment and included screenshots/GIFs to showcase the graph. However, since enterprise account features are not supported at the moment, sharing a direct graph link will be delayed.


View entire conversation on ReviewNB

@NeilJohnson0930 NeilJohnson0930 modified the milestones: Sprint 21, Sprint 24 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Dynamic Knowledge Graph feature with Neo4j Graph
5 participants