Added pt-BR translations for permissions alerts #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 16, 2016 13:09
As a first commit, I added two portuguese localizations to test if it will work using the Permissions app
Commentted out the logging lines
All translated alert titles that I could find using Permissions.app. I could not run the app in a Device, so some translations could be missing
Removed translation of a iOS 10 alert. iOS 10 alerts will be dismissed by DeviceAgent, so there is no need of it here
Uncommented the line that Logs the alert title because this line must be commented only in debug mode
|
Can one of the admins verify this patch? |
|
Jenkins test this please |
|
Perfect. Thank you very much. |
jmoody
added a commit
to calabash/DeviceAgent.iOS
that referenced
this pull request
Nov 22, 2016
|
Thank you very much. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added translations for the Permissions Alerts messages, because Calabash was not able to automatically dismiss Portuguese alerts.
I used Permissions.app to get this messages. I could not run Permissions.app in a Device, so all messages came from an iPhone 6 simulator, running iOS 9.3. Ruby 2.3.1p112 and calabash-ios 0.20.3.
Then I used Permissions.app to check if this solved the problem and the scenarios passed.
For newer versions of iOS SDK, I opened the Issue #1226 in the calabash-ios repository, so DeviceAgent can also be updated.
This is my first pull request for run_loop. Please forgive me if something is not OK. Anything that should change, please let me know and I will fix it in no time.