[Wf-Diagnostics] fix the usage logs data emitted by wf diagnostics #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
sankari165
changed the title
jakobht
approved these changes
Jan 15, 2025
|
Maybe we should use an ISO8601 string for the date, I see it's JSON serialized? Not sure what it's used for though? |
|
I did consider the string option too. The context is that these are data emitted into kafka and then into pinot (not related to visibility) every time diagnostics is run. The purpose is to be able to query the usage of the diagnostics over time. Thats why having them in utc will help with querying and I chose it over the date string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
diagnostic start and end time are sent in millisecoonds
Why?
The message schema expects it in milliseconds
How did you test it?
Potential risks
Release notes
Documentation Changes