Remove WorkflowIDExternal/InternalRateLimitEnabled dynamic configs #6618
+170
−391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arzonus
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
arzonus
changed the title
jakobht
approved these changes
Jan 15, 2025
arzonus
deleted the
remove-workflow-id-internal-external-ratelimit-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
WorkflowIDInternalRateLimitEnabledandWorkflowIDExternalRateLimitEnableddynamic configs have been removed. All related logic in tests and code have been removed too.Why?
Currently we have 4 dynamic config flags for controlling if a domain will be ratelimited by the per-workflow ratelimiter:
We do no longer need the *Enabled properties. We can just set the RPS for domains that should not be ratelimited to MAXINT
How did you test it?
Unit tests
Potential risks
WorkflowID Rate Limit will not allow executions or will not limit executions
Release notes
Documentation Changes