refactor historyEngineImpl.getMutableStateOrPolling #6584
Merged
+92
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactroring before bugfixing. Extracted longPolling part to a separate method so it is easier to read. Essentially, there are two distinct parts: 1) getting mutable state immediately 2) waiting for the desired eventID to appear in a running workflow Initial 150+ lines code is just hard to read because two different things are combined in one.
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Extracted longPolling part to a separate method so it is easier to read.
Essentially, there are two distinct parts:
Initial 150+ lines code is just hard to read because two different
things are combined in one.
Why?
Refactroring before bugfixing.
How did you test it?
Unit-tests
Potential risks
Release notes
Documentation Changes