Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matching] Simplity poller extraction in task list manager #6333

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[matching] Simplity poller extraction in task list manager #6333

merged 2 commits into from
Oct 8, 2024

Conversation

3vilhamster
Copy link
Contributor

@3vilhamster 3vilhamster commented Oct 7, 2024 •
edited
Loading

What changed?

  • simplified multiple hot paths in matching to remove extra allocations during tasklist manager lifecycle.
  • removed redundant checks when tasklist manager provides empty time to the history poller cache
  • Isolated poller.History to interface for better testability in the future.

Why?
In some cases, matching queries history cache is a hot path that puts pressure on the GC.
I've removed extra operations on top of the stack while we've observed a heavy load.

How did you test it?
Unit test/matching integration tests

Potential risks
None

Release notes

Documentation Changes

@3vilhamster 3vilhamster merged commit 2757192 into cadence-workflow:master Oct 8, 2024
18 checks passed
@3vilhamster 3vilhamster deleted the optimize-matching branch October 8, 2024 17:00
Shaddoll added a commit to Shaddoll/cadence that referenced this pull request Oct 14, 2024
@Shaddoll
Revert "[matching] Simplity poller extraction in task list manager (c…
39a85ce 
…adence-workflow#6333)"

This reverts commit 2757192.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkrotx dkrotx dkrotx approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3vilhamster @dkrotx