Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert codecov #5889

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Revert codecov #5889

merged 2 commits into from
Apr 8, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Apr 8, 2024

What changed?
Revert codecov change

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #5889 (c0e2985) into master (45bf802) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head c0e2985 differs from pull request most recent head dfc3386. Consider uploading reports for the commit dfc3386 to get more accurate results

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bf802...dfc3386. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 018ebf14-1323-4459-ad92-0abde985c5c2

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.02%) to 67.287%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.7%
common/membership/hashring.go 2 82.23%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.74%
tools/cli/admin_db_decode_thrift.go 3 69.23%
service/worker/scanner/executor/runq.go 3 85.48%
Totals Coverage Status
Change from base Build 018ebf07-7f80-42c3-886d-6422e0fcc1b8: -0.02%
Covered Lines: 98074
Relevant Lines: 145755

💛 - Coveralls

@Shaddoll Shaddoll merged commit c7d1957 into cadence-workflow:master Apr 8, 2024
16 of 18 checks passed
@Shaddoll Shaddoll deleted the codecov branch April 8, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants