Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for write-functions in dual manager #5847

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Apr 2, 2024

What changed?
Add tests for write functions (record/update/delete) in dual manager

Why?
code coverage week

How did you test it?
unti test

Potential risks

Release notes

Documentation Changes

@bowenxia bowenxia enabled auto-merge (squash) April 2, 2024 23:48
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #5847 (99f8b3a) into master (f789461) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 99f8b3a differs from pull request most recent head 3707af4. Consider uploading reports for the commit 3707af4 to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/persistence/visibility_dual_manager.go 69.69% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f789461...3707af4. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 3, 2024

Pull Request Test Coverage Report for Build 018ea23b-4331-47a7-91ca-a07dcfa3678e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.04%) to 65.891%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
common/util.go 2 91.78%
service/matching/taskListManager.go 2 80.96%
common/membership/hashring.go 2 82.23%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.18%
service/matching/taskReader.go 5 84.08%
common/task/fifo_task_scheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 018ea20d-ef6f-473d-917f-25588d769ad8: 0.04%
Covered Lines: 96423
Relevant Lines: 146338

💛 - Coveralls

@bowenxia bowenxia changed the title add tests for write functions in dual manager add tests for write-functions in dual manager Apr 3, 2024
@bowenxia bowenxia merged commit 5ecb9f9 into master Apr 3, 2024
18 of 19 checks passed
@bowenxia bowenxia deleted the xbowen_dual_manager_test00 branch April 3, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants