Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idls #5813

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Update idls #5813

merged 2 commits into from
Mar 25, 2024

Conversation

Shaddoll
Copy link
Member

What changed?

  • Update idls
  • Update internal types and mappers to support new idls

Why?

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Merging #5813 (a8f0a4c) into master (3498c59) will increase coverage by 0.38%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
common/types/mapper/proto/api.go 98.31% <100.00%> (+<0.01%) ⬆️
common/types/mapper/thrift/shared.go 97.61% <100.00%> (+<0.01%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07644ce...a8f0a4c. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 23, 2024

Pull Request Test Coverage Report for Build 018e7653-eee5-4f3c-aad4-b137bc5c572c

Details

  • 16 of 31 (51.61%) changed or added relevant lines in 3 files are covered.
  • 70 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 65.221%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/types/shared.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.42%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/parallel_task_processor.go 2 93.06%
common/task/fifo_task_scheduler.go 2 83.51%
common/util.go 2 91.78%
common/membership/hashring.go 2 82.23%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 6 86.78%
service/history/execution/mutable_state_task_refresher.go 46 58.86%
Totals Coverage Status
Change from base Build 018e75b7-51b2-4078-8601-a9a02744375a: 0.02%
Covered Lines: 95308
Relevant Lines: 146130

💛 - Coveralls

Copy link
Contributor

@ketsiambaku ketsiambaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shaddoll Shaddoll merged commit 27234b9 into cadence-workflow:master Mar 25, 2024
20 checks passed
@Shaddoll Shaddoll deleted the request branch March 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants