Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce new line coverage 85% #5805

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Mar 21, 2024

What changed?
Trying codecov's patch coverage setting to enforce new line coverage per diff to be > 85%.

How did you test it?
I added a new dummy function without tests in the first commit on this PR. Codecov patch check failed with below message:

Screenshot 2024-03-21 at 10 37 13 AM

Then I added tests to cover half of the lines:
Screenshot 2024-03-21 at 11 31 27 AM

Then I removed the dummy function so PR only has yml changes:

Screenshot 2024-03-21 at 12 10 14 PM

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #5805 (b73923e) into master (cff5a94) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff5a94...b73923e. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 21, 2024

Pull Request Test Coverage Report for Build 018e6249-5b94-4d76-8d8d-11d84d4b9f8d

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 65.383%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 84.54%
common/util.go 2 91.78%
common/persistence/statsComputer.go 3 94.64%
service/history/task/fetcher.go 3 85.57%
service/matching/taskListManager.go 4 79.7%
service/history/task/transfer_standby_task_executor.go 6 86.6%
Totals Coverage Status
Change from base Build 018e61ef-a6f4-4969-adc1-af73494586b3: 0.02%
Covered Lines: 95576
Relevant Lines: 146178

💛 - Coveralls

@taylanisikdemir taylanisikdemir force-pushed the taylan/new_line_enforcement branch from 5e0acd0 to 826bd4e Compare March 21, 2024 17:46
Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline that we don't expect this to hit a problem with the nondeterministic coverage problem due to it being patch related only

@taylanisikdemir taylanisikdemir merged commit 39e19c0 into cadence-workflow:master Mar 21, 2024
20 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/new_line_enforcement branch March 21, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants