-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce new line coverage 85% #5805
Enforce new line coverage 85% #5805
Conversation
Codecov Report
Additional details and impacted filessee 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e6249-5b94-4d76-8d8d-11d84d4b9f8dDetails
💛 - Coveralls |
5e0acd0
to
826bd4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline that we don't expect this to hit a problem with the nondeterministic coverage problem due to it being patch related only
What changed?
Trying codecov's
patch
coverage setting to enforce new line coverage per diff to be > 85%.How did you test it?
I added a new dummy function without tests in the first commit on this PR. Codecov patch check failed with below message:
Then I added tests to cover half of the lines:

Then I removed the dummy function so PR only has yml changes: