Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed schema files #5040

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Embed schema files #5040

merged 1 commit into from
Dec 9, 2022

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Dec 8, 2022

What changed?

  • Refactor schema update tool to support embeddings
  • Add schema embeddings

Why?

  • To make it easier to access schema files from monorepo

How did you test it?
local test, unit test

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll force-pushed the embed branch 3 times, most recently from 1517f23 to 9716032 Compare December 8, 2022 17:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0184f2f0-0a8a-471c-b167-ec2c459e7957

  • 16 of 35 (45.71%) changed or added relevant lines in 4 files are covered.
  • 63 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.009%) to 57.348%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/common/schema/setuptask.go 3 5 60.0%
tools/common/schema/handler.go 2 7 28.57%
tools/common/schema/updatetask.go 8 20 40.0%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/persistence/historyManager.go 2 66.67%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/parallelTaskProcessor.go 2 92.75%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/handler.go 2 47.15%
service/history/task/transfer_standby_task_executor.go 2 88.08%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
service/frontend/workflowHandler.go 4 59.98%
Totals Coverage Status
Change from base Build 0184ef4f-2220-4702-afd6-6d9859f06d6d: 0.009%
Covered Lines: 85296
Relevant Lines: 148734

💛 - Coveralls

@Shaddoll Shaddoll merged commit 0726498 into cadence-workflow:master Dec 9, 2022
@Shaddoll Shaddoll deleted the embed branch December 9, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants