Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a dynamic config for cassandra all consistency level delete #5000

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Sep 23, 2022

What changed?
Introduce a dynamic config for cassandra all consistency level delete

Why?
feature flag

How did you test it?

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll force-pushed the delete-all branch 5 times, most recently from 62126c9 to db59b92 Compare September 23, 2022 19:09
@coveralls
Copy link

coveralls commented Sep 26, 2022

Pull Request Test Coverage Report for Build 01837ab5-14d3-45d3-96a4-f5709cbbbd74

  • 48 of 66 (72.73%) changed or added relevant lines in 18 files are covered.
  • 81 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.004%) to 57.265%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/nosql/nosqlplugin/mongodb/plugin.go 0 2 0.0%
common/persistence/persistence-tests/persistenceTestBase.go 0 4 0.0%
common/persistence/nosql/nosqlplugin/cassandra/db.go 8 20 40.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.66%
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/util.go 2 52.74%
service/history/handler.go 2 47.3%
service/matching/matcher.go 2 91.46%
service/history/task/fetcher.go 3 91.75%
service/matching/taskListManager.go 3 76.87%
common/persistence/serialization/parser.go 4 62.41%
common/persistence/serialization/thrift_decoder.go 4 53.06%
Totals Coverage Status
Change from base Build 01837a94-cac1-4f41-a994-e1357753d5a6: -0.004%
Covered Lines: 85124
Relevant Lines: 148648

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants