Update Cassandra deletes to use ALL consistency level #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackLK
reviewed
Aug 31, 2022
ZackLK
reviewed
Aug 31, 2022
The existing persistence and integration tests. |
Shaddoll
force-pushed
the
delete-all
branch
2 times, most recently
from
3cf8a94 to
1340109
Compare
vytautas-karpavicius
approved these changes
Sep 1, 2022
| func (c client) IsCassandraConsistencyError(err error) bool { | ||
| if req, ok := err.(gogocql.RequestError); ok { | ||
| // 0x1000 == UNAVAILABLE | ||
| return req.Code() == 0x1000 |
There was a problem hiding this comment.
nit: It may be worth defining private const for such magical values.
Groxx
pushed a commit
that referenced
this pull request
Sep 1, 2022
Groxx
pushed a commit
that referenced
this pull request
Sep 6, 2022
Groxx
pushed a commit
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
existing test
staging2 test
Potential risks
If deletes fail with ALL consistency level, we fallback to LOCAL_QUORUM consistency level. There should be no risk
Release notes
Documentation Changes