Implement optional redirect when max-size is exceeded #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For [our](https://pypi.org) use-case, we prefer to display a static image, indicating why the image is not loading, namely:  This is now one of the only divergences that aren't deployment centric in our fork of go-camo, so I'd be happy to do whatever is necessary to get it merged so we can just run from published images :)
|
@ewdurbin Patch looks good. Making the new feature a non-default cli flag is great. ❤️ |
jdreesen
reviewed
Jun 18, 2024
jdreesen
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For our use-case, we prefer to display a static image, indicating why the image is not loading, namely:
This is now one of the only divergences that aren't deployment centric in our fork of go-camo, so I'd be happy to do whatever is necessary to get it merged so we can just run from published images :)
Checklist