Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored settings caching #1823

Merged
merged 11 commits into from
May 25, 2016
Merged

Refactored settings caching #1823

merged 11 commits into from
May 25, 2016

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented May 25, 2016 •
edited
Loading

Closes #1817.

@GrahamCampbell GrahamCampbell added this to the V2.3.0 milestone May 25, 2016
@GrahamCampbell GrahamCampbell changed the title WIP Refactored settings caching May 25, 2016
jbrooksuk
jbrooksuk reviewed May 25, 2016
View reviewed changes
app/Settings/Cache.php

use Illuminate\Filesystem\Filesystem;

class Cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing class header?

@jbrooksuk
Copy link
Member

I've found an issue where if you change a setting from the dashboard, it takes another refresh to show the updated values.

@GrahamCampbell GrahamCampbell merged commit e39a3cd into 2.3 May 25, 2016
@GrahamCampbell GrahamCampbell deleted the settings-cache branch May 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @jbrooksuk