Add rfc80 clean arch #11396
Merged
Add rfc80 clean arch #11396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haynescd
force-pushed
the
add-rfc80-clean-arch
branch
from
4d51870 to
8dc093b
Compare
haynescd
requested review from
inodb,
onursumer,
dippindots,
fuzhaoyuan and
alisman
|
Will the services in |
onursumer
approved these changes
Feb 19, 2025
| @@ -0,0 +1,4 @@ | |||
| package org.cbioportal.infrastructure.repository.clickhouse.studyview; | |||
|
|
|||
| public interface ClickhouseStudyViewFilterMapper { | |||
There was a problem hiding this comment.
Is this empty interface intentional?
There was a problem hiding this comment.
Yea, because it is mapped to the StudyViewFilterMapper.xml that has all the common logic for the studyViewFilter
|
inodb
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated RFC80 code to utilize new architecture.
I have not refactored all the code, but have deprecated most of it.
I moved everything under domain package