Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Standalone Configuration Information Section in Documentation #11378

Conversation

JREastonMarks
Copy link
Contributor

@JREastonMarks JREastonMarks commented Feb 6, 2025

#11373 Creates Standalone Configuration Information Section in Documentation

@JREastonMarks JREastonMarks marked this pull request as ready for review February 6, 2025 01:31
## Setup Instructions

### Docker Configuration and Setup
Our docker configuration is based off the default cBioPortal docker configuration however we have made some changes to support our requirements. We create two networks in this deployment. The first being a bridge network that allows the services to connect to the outside world. The second is an internal network that only allows for services to talk to other services in that network. Most of the services are configured to use the internal network, with the exception being the NGINX and cBioPortal services. The NGINX needs to be able to communicate with the outside world in order to make the cBioPortal instance available to the outside world. The cBioPortal instance needs to be able to communicate with the outside world in order to allow for authentication with an outside service. However, if the cBioPortal instance does not authentication then the service can be deployed only on the internal network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo

Suggested change
Our docker configuration is based off the default cBioPortal docker configuration however we have made some changes to support our requirements. We create two networks in this deployment. The first being a bridge network that allows the services to connect to the outside world. The second is an internal network that only allows for services to talk to other services in that network. Most of the services are configured to use the internal network, with the exception being the NGINX and cBioPortal services. The NGINX needs to be able to communicate with the outside world in order to make the cBioPortal instance available to the outside world. The cBioPortal instance needs to be able to communicate with the outside world in order to allow for authentication with an outside service. However, if the cBioPortal instance does not authentication then the service can be deployed only on the internal network.
Our docker configuration is based off the default cBioPortal docker configuration however we have made some changes to support our requirements. We create two networks in this deployment. The first being a bridge network that allows the services to connect to the outside world. The second is an internal network that only allows for services to talk to other services in that network. Most of the services are configured to use the internal network, with the exception being the NGINX and cBioPortal services. The NGINX needs to be able to communicate with the outside world in order to make the cBioPortal instance available to the outside world. The cBioPortal instance needs to be able to communicate with the outside world in order to allow for authentication with an outside service. However, if the cBioPortal instance does not authenticate then the service can be deployed only on the internal network.

Copy link
Contributor

@fuzhaoyuan fuzhaoyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will it show up somewhere in the Docs? Looks like it will

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks @JREastonMarks !

A few small things:

  • To get the doc to show up in the TOC, you'll need to add it to SUMMARY.md
  • We recently started adding an addon/ folder to the cbioportal-docker-compose repo (see for clickhouse: https://github.com/cbioPortal/cbioportal-docker-compose#clickhouse-mode). Idea being that you could sorta layer in additional services etc by adding additional compose files. Maybe some of the compose code in the docs could go there. Not necessary to do now tho, but maybe a good follow up. I included @zainasir to review
  • OncoKB data requires a license, it doesn't seem to be explicitly mentioned here?

@fuzhaoyuan fuzhaoyuan requested a review from alisman February 24, 2025 16:26
@alisman alisman merged commit 9f88afc into cBioPortal:master Feb 24, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants