Remove NA label when NA=0 in filter chart #5126
Merged
+15
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#11056
I can reproduce this issue. Checking the code, it was due to thecomputed method
labelShowingNA
is not checking whetherNA=0
. A simple fix would be adding an if clause so that whenlabelNA==='0'
then returnnull
. I don't think backend changes are needed here.Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?