Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Added boxplot stats as tooltip for axis label #5125

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

rishisulakhe
Copy link
Contributor

Fix cBioPortal/cbioportal#11245

Describe changes proposed in this pull request:

  • Added Axis Label Hover Events: Implement event handlers for axis labels to trigger tooltips when hovered.
  • These changes allow users to view box plot statistics by hovering over both the box plot and the axis labels.

Checks

  • [✓ ] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [ ✓] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [✓ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

Screenshot 2025-03-10 230119

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit d61e480
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67d078ddbdab7e0007f770f9
😎 Deploy Preview https://deploy-preview-5125.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rishisulakhe
Copy link
Contributor Author

Hello @alisman
Please take a look at this PR and suggest any required changes
Thankyou.

@alisman
Copy link
Collaborator

alisman commented Mar 11, 2025

@rishisulakhe thank you for doing this. can you rebase (and resolve conflicts)?

@@ -939,6 +979,57 @@ export default class BoxScatterPlot<
}
}

@autobind
private getAxisLabelTooltipComponent() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see if there is any way to consolidate this code with the implementation that does the same thing for the box plots themselves.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishisulakhe i tested this and looks good. just respond to the above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on this , will commit very soon

Copy link
Collaborator

@alisman alisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see note

@alisman alisman merged commit 777550c into cBioPortal:master Mar 11, 2025
9 of 11 checks passed
@alisman
Copy link
Collaborator

alisman commented Mar 11, 2025

@rishisulakhe thanks. merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add boxplot stats as tooltip for axis label
2 participants