-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Added boxplot stats as tooltip for axis label #5125
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello @alisman |
@rishisulakhe thank you for doing this. can you rebase (and resolve conflicts)? |
@@ -939,6 +979,57 @@ export default class BoxScatterPlot< | |||
} | |||
} | |||
|
|||
@autobind | |||
private getAxisLabelTooltipComponent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see if there is any way to consolidate this code with the implementation that does the same thing for the box plots themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishisulakhe i tested this and looks good. just respond to the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on this , will commit very soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see note
@rishisulakhe thanks. merged |
Fix cBioPortal/cbioportal#11245
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?