Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue-11412 #5122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nivedita-Chhokar
Copy link

Fix cBioPortal/cbioportal#11412

Describe changes proposed in this pull request:

  • created react component
  • replaced all the iframe loader with minervaViewer

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

none

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Mar 8, 2025

Deploy Preview for cbioportalfrontend failed. Why did it fail? →

Name Link
🔨 Latest commit a83972d
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67cc05d21446b70008292256

Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nivedita-Chhokar Thanks for opening a pull request. This issue requires purely frontend changes. So, we can test it by using the frontend generated by netlify/cbioportalfrontend/deploy-preview. I think there are some build issues in this pull request. You can see circleci's build_frontend test is failing, and netlify/cbioportalfrontend/deploy-preview can't build this frontend. Could you take a look at whether it's building successfully on your local?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace iframe with React Component for Minerva
2 participants