Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky e2e remote tests #5119

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Fix flaky e2e remote tests #5119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15818f7
fix flaky e2e tests
Mar 3, 2025
8a17ce4
fix home page test where query by gene button isn't pressed
Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...ference/patient_page_valid_after_cohort_navigation_element_chrome_1600x1000.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion end-to-end-test/remote/specs/core/genomicEvolution.screenshot.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ describe('Patient View Genomic Evolution tab screenshot tests', () => {
assertScreenShotMatch(res);
});
it('pvge line chart log scale', async () => {
await jsApiClick('input[data-test="VAFLogScale"]');
await setCheckboxChecked(true, 'input[data-test="VAFLogScale"]');
await (await getElement('body')).moveTo({ xOffset: 0, yOffset: 0 });

const res = await browser.checkElement('[data-test=VAFChartWrapper]');
assertScreenShotMatch(res);
Expand Down
6 changes: 5 additions & 1 deletion end-to-end-test/remote/specs/core/home.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,11 @@ describe('genetic profile selection in front page query form', function() {
await clickModifyStudySelectionButton();

//deselect other study
await clickElement('[data-test="StudySelect"]');
await (
await getElement('.studyItem_ampca_bcm_2016')
).waitForDisplayed();

await clickElement('.studyItem_ampca_bcm_2016');

await clickQueryByGeneButton();

Expand Down
2 changes: 2 additions & 0 deletions end-to-end-test/remote/specs/core/resultsOncoprintColorConfig.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ describe('oncoprint colors', () => {
const trackOptionsElts = await getNthOncoprintTrackOptionsElements(
5
);
await (await getElement(trackOptionsElts.button_selector)).moveTo();
// open menu
await clickElement(trackOptionsElts.button_selector);
await (
Expand Down Expand Up @@ -141,6 +142,7 @@ describe('oncoprint colors', () => {
const trackOptionsElts = await getNthOncoprintTrackOptionsElements(
5
);
await (await getElement(trackOptionsElts.button_selector)).moveTo();
await clickElement(trackOptionsElts.button_selector);
await (
await getElement(trackOptionsElts.dropdown_selector)
Expand Down
2 changes: 1 addition & 1 deletion end-to-end-test/remote/specs/core/screenshot.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function runResultsTestSuite(prefix, options = {}) {

it(`${prefix} igv_tab tab`, async function() {
await clickElement('a.tabAnchor_cnSegments');
await getElement('.igv-column-container', { timeout: 20000 });
await (await getElement('.igv-column-container')).waitForDisplayed();
const res = await checkElementWithMouseDisabled('.pillTabs');
assertScreenShotMatch(res);
});
Expand Down