Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline: hide superfluous drag-to-zoom button when zooming is disabled #5096

Conversation

FilledEther20
Copy link
Contributor

Fixes cBioPortal/cbioportal#11354:double drag to zoom button on patient view
Describe changes proposed in this pull request:

-Eliminates the superfluous "drag to zoom" button in the patient view.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Screenshot

Before:-
image

Updated:-
Update

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 8c8e8a8
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/679a652f316df700082355e8
😎 Deploy Preview https://deploy-preview-5096.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman alisman changed the title Resolves Issue#11354 Timeline: hide superfluous drag-to-zoom button when zooming is disabled Jan 29, 2025
@alisman alisman merged commit 7d2d54a into cBioPortal:master Jan 29, 2025
4 of 6 checks passed
@inodb inodb added the bug label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double drag to zoom button on patient view
3 participants