bug fix: case no meta data from mutational signatures endpoint #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inodb I will test it with the pancan study locally before making this ready for review (just to be sure) |
inodb
reviewed
Aug 10, 2023
Comment on lines
56
to
72
| export function formatLegendTopAxisPoints(data: IMutationalCounts[]) { | ||
| /*export function formatLegendTopAxisPoints(data: IMutationalCounts[]) { | ||
| const constant_value = _.max(data.map(item => item.value)) || 0; | ||
| const groupedData = _.groupBy(getColorsForSignatures(data), g => g.group); | ||
| return getColorsForSignatures(data).map(entry => ({ | ||
| x: entry.mutationalSignatureLabel, | ||
| y: constant_value + constant_value * 0.1, | ||
| color: entry.colorValue, | ||
| })); | ||
| } | ||
| }*/ | ||
|
|
||
| export function transformMutationalSignatureData(dataset: IMutationalCounts[]) { | ||
| /*export function transformMutationalSignatureData(dataset: IMutationalCounts[]) { | ||
| const transformedDataSet = dataset.map((obj: IMutationalCounts) => { | ||
| const transformedDataSet = dataset.map((obj: IMutationalCounts) => { | ||
| let referenceTransformed = -Math.abs(obj.value); | ||
| return { ...obj, referenceTransformed }; | ||
| }); | ||
| return transformedDataSet; | ||
| }); | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
what were these used for previously?
There was a problem hiding this comment.
formatLegendTopAxisPoints is not needed anymore since this behavior is captured in the @computed formatLegendTopAxisPoints. The second function transformMutationalSignatureData is to show the reference counts but we will not show them in this chart. (I have a separate branch with the reference signature so the function is not lost)
Updated alternative name for missing labels Update PatientViewPageUtils.tsx updated label placement removed unused functions Prettier fix local
TJMKuijpers
force-pushed
the
mutational-signature-bug-fix
branch
from
52b5948 to
5aaf030
Compare
inodb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional check when
fetchAllMutationalSignatureCountMetaDatadoes return an empty array.In this case, the stable ID (which should always be defined) is used the create the mutational signature label.