Fix pathway table page reset issue #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue seems fixed. Thanks @gorkemsolun! Looks like prettier check is failing though (https://app.circleci.com/pipelines/github/cBioPortal/cbioportal-frontend/11535/workflows/09f992d0-fc12-4d32-b2b4-7ed65d28fe0c/jobs/147520). Usually prettier runs automatically before each commit, but looks like it didn't for this PR. Can you manually run prettier for the modified file and updated the PR? |
gorkemsolun
force-pushed
the
master-fix-pathway-table-reset
branch
from
594429c to
f00a4af
Compare
onursumer
changed the title
onursumer
approved these changes
Aug 4, 2023
onursumer
force-pushed
the
master-fix-pathway-table-reset
branch
from
f00a4af to
01c262a
Compare
When the component mounts, we need to find the page number for the selected pathway. We can use the current data and data store to determine the page number.
dippindots
force-pushed
the
master-fix-pathway-table-reset
branch
from
01c262a to
1d8d3e8
Compare
|
@gorkemsolun @onursumer Is this one ready to merge? If it's ok, I will merge it after the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#10085