Persist text color on icon in group comparison buttons #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
approved these changes
Jul 24, 2023
|
@zhx828 looks good. needs a few screen shot updates. let me know if you need help with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to use the same text color on the icon and also the left border of the icon. We do that in the study view. Let me know whether you like this change.
Ideally we should use the PillTag for the button, but I understand the complexity of this component.
We should also add a bit more padding for the button, so the left border of the delete icon shows up better. But that seems to have bigger impact, so I didn't include.
Current
Proposed