🐛 Update Freq Col Alignment in Timeline Event Availability Chart #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haynescd
force-pushed
the
feature/ch/Fix-Timeline-Events-Availabilty-Chart-Alignment
branch
from
dc58ede to
f834440
Compare
|
|
alisman
reviewed
Mar 23, 2023
| @@ -241,7 +253,20 @@ export default class ClinicalEventTypeCountTable extends React.Component< | |||
| return { | |||
| [ClinicalEventTypeCountColumnKey.CLINICAL_EVENT_TYPE]: 0, | |||
| [ClinicalEventTypeCountColumnKey.COUNT]: 0, | |||
| [ClinicalEventTypeCountColumnKey.FREQ]: 0, | |||
| [ClinicalEventTypeCountColumnKey.FREQ]: correctMargin( | |||
There was a problem hiding this comment.
what's this about? (i see it isn't new)
There was a problem hiding this comment.
Added this to dynamically calculate the marge based on freq string.
This is similar to how MultiSelectionTable.tsx aligns the Freq column
haynescd
force-pushed
the
feature/ch/Fix-Timeline-Events-Availabilty-Chart-Alignment
branch
from
f834440 to
a024a40
Compare
haynescd
deleted the
feature/ch/Fix-Timeline-Events-Availabilty-Chart-Alignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes proposed in this pull request: