-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter SV by custom driver annotations in oncoprint and study page #4552
Filter SV by custom driver annotations in oncoprint and study page #4552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, is there any instructions on how to test this pull request? Also, it's good to get @alisman's opinion too.
9b637a2
to
2006e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BasLee It looks good to me now. I wish to get @alisman's comment about the waiting sequence in my comment. If he thinks it's ok, I think this is good to go. And I also noticed that the prettier test is failing. Maybe you can try to run prettier locally again.
If we decide to merge, please make sure we wait until the deployment date (next Tuesday) to release this with the backend together.
2006e93
to
21bf551
Compare
b64b0c0
to
b368c3f
Compare
b368c3f
to
4626705
Compare
Filter structural variants by custom driver annotations in oncoprint and on study page.
Depends on backend PR cBioPortal/cbioportal#10092 for query and es_0 data changes.
Changes
ResultsViewPageStore
analogous to CNA and mutations.StudyViewPageStore.filters
these tiers are requested, but subsequent api calls depending onfilters
are not waiting for this info.initialFiltersRemote
andfiltersRemote
, which allows api calls to wait for a fully loadedfilters
.custom-driver-annotations.spec.js
Study View
Class 2
andClass 4
Oncoprint