Fix flaky e2e remote tests (#5119)

* fix flaky e2e tests * fix home page test where query by gene button isn't pressed --------- Co-authored-by: Bryan Lai <laib1@mskcc.org>
cBioPortal · Mar 4, 2025 · b0e0b32 · b0e0b32
1 parent 5fb784d
commit b0e0b32
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/...ference/patient_page_valid_after_cohort_navigation_element_chrome_1600x1000.png b/...ference/patient_page_valid_after_cohort_navigation_element_chrome_1600x1000.png
diff --git a/end-to-end-test/remote/specs/core/genomicEvolution.screenshot.spec.js b/end-to-end-test/remote/specs/core/genomicEvolution.screenshot.spec.js
@@ -86,7 +86,8 @@ describe('Patient View Genomic Evolution tab screenshot tests', () => {
         assertScreenShotMatch(res);
     });
     it('pvge line chart log scale', async () => {
-        await jsApiClick('input[data-test="VAFLogScale"]');
+        await setCheckboxChecked(true, 'input[data-test="VAFLogScale"]');
+        await (await getElement('body')).moveTo({ xOffset: 0, yOffset: 0 });
 
         const res = await browser.checkElement('[data-test=VAFChartWrapper]');
         assertScreenShotMatch(res);

diff --git a/end-to-end-test/remote/specs/core/home.spec.js b/end-to-end-test/remote/specs/core/home.spec.js
@@ -482,7 +482,11 @@ describe('genetic profile selection in front page query form', function() {
         await clickModifyStudySelectionButton();
 
         //deselect other study
-        await clickElement('[data-test="StudySelect"]');
+        await (
+            await getElement('.studyItem_ampca_bcm_2016')
+        ).waitForDisplayed();
+
+        await clickElement('.studyItem_ampca_bcm_2016');
 
         await clickQueryByGeneButton();
 

diff --git a/end-to-end-test/remote/specs/core/resultsOncoprintColorConfig.spec.js b/end-to-end-test/remote/specs/core/resultsOncoprintColorConfig.spec.js
@@ -49,6 +49,7 @@ describe('oncoprint colors', () => {
             const trackOptionsElts = await getNthOncoprintTrackOptionsElements(
                 5
             );
+            await (await getElement(trackOptionsElts.button_selector)).moveTo();
             // open menu
             await clickElement(trackOptionsElts.button_selector);
             await (
@@ -141,6 +142,7 @@ describe('oncoprint colors', () => {
             const trackOptionsElts = await getNthOncoprintTrackOptionsElements(
                 5
             );
+            await (await getElement(trackOptionsElts.button_selector)).moveTo();
             await clickElement(trackOptionsElts.button_selector);
             await (
                 await getElement(trackOptionsElts.dropdown_selector)

diff --git a/end-to-end-test/remote/specs/core/screenshot.spec.js b/end-to-end-test/remote/specs/core/screenshot.spec.js
@@ -35,7 +35,7 @@ function runResultsTestSuite(prefix, options = {}) {
 
     it(`${prefix} igv_tab tab`, async function() {
         await clickElement('a.tabAnchor_cnSegments');
-        await getElement('.igv-column-container', { timeout: 20000 });
+        await (await getElement('.igv-column-container')).waitForDisplayed();
         const res = await checkElementWithMouseDisabled('.pillTabs');
         assertScreenShotMatch(res);
     });