-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid names in import object #30
Merged
guybedford
merged 3 commits into
bytecodealliance:main
from
eduardomourar:fix/update-wit-component
Feb 17, 2023
Merged
fix: invalid names in import object #30
guybedford
merged 3 commits into
bytecodealliance:main
from
eduardomourar:fix/update-wit-component
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR, with #31 merged there should no longer be update issues if you're able to rebase to the latest main. |
081ab71
to
1070c89
Compare
This prepares the ground for when TypeScript will have support for "Arbitrary module namespace identifier names": microsoft/TypeScript#40594
1070c89
to
c54c4f5
Compare
This is still failing unfortunately -
|
The TypeScript compiler might take same time to support this syntax. Should we just generate something like this, instead? import { WasiClocks as WasiClocksImports } from './imports/wasi-clocks';
import { WasiDefaultClocks as WasiDefaultClocksImports } from './imports/wasi-default-clocks';
import { WasiStderr as WasiStderrImports } from './imports/wasi-stderr';
export interface ImportObject {
'wasi-clocks': typeof WasiClocksImports,
'wasi-default-clocks': typeof WasiDefaultClocksImports,
'wasi-stderr': typeof WasiStderrImports,
}
export namespace SomeCommand {
export function command(stdin: number, stdout: number, args: string[], envVars: [string, string][], preopens: [number, string][]): void;
}
export function instantiate(
compileCore: (path: string, imports: Record<string, any>) => Promise<WebAssembly.Module>,
imports: ImportObject,
instantiateCore?: (module: WebAssembly.Module, imports: Record<string, any>) => Promise<WebAssembly.Instance>
): Promise<typeof Stedi>; |
Sure, that can work. |
68340b9
to
88cd183
Compare
Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the ground for when TypeScript will have support for "Arbitrary module namespace identifier names": microsoft/TypeScript#40594.Instead, we will export aninterface
in replacement of anamespace
.