Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring -terraform-bin parameter when running with -output=commands #70

Closed
p1gmale0n opened this issue Dec 13, 2023 · 3 comments · Fixed by #83
Closed

Ignoring -terraform-bin parameter when running with -output=commands #70

p1gmale0n opened this issue Dec 13, 2023 · 3 comments · Fixed by #83
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@p1gmale0n
Copy link

When executing the command with the parameter -output=commands, it appears that the -terraform-bin parameter is being ignored.

example:

> tfautomv -terraform-bin=terragrunt --dry-run
Running "terraform init"...
Running "terraform plan"...
╷
│ Moves
│ ╷
│ │ From: random_pet.dog
│ │ To:   random_pet.cat
│ ╵
╵
> tfautomv -terraform-bin=terragrunt -output=commands
Running "terraform init"...
Running "terraform plan"...
terraform state mv "random_pet.dog" "random_pet.cat"

> tfautomv --version
v0.5.4
@busser
Copy link
Owner

busser commented Jan 30, 2024

This isn't something I anticipated, and I agree with you that what the -output=commands flag should respect the -terraform-bin flag. Thanks for reporting it!

@busser busser added bug Something isn't working good first issue Good for newcomers labels Jan 30, 2024
@strowi
Copy link

strowi commented Feb 18, 2024

Thx, was banging my head wondering why it didn't work (just starting to test tfautomv). Just stumbled into the same problem, tfautomv --terraform-bin=terragrunt --output=commands --skip-init shows only the moves, not the commands.

busser added a commit that referenced this issue Feb 26, 2024
@busser
🐛 Respect --terraform-bin flag in output
6c2dfef 
Fixes #70.

Adds end-to-end tests for the different output formats.

Removes an extra space from generated commands when the target workspace
is the current working directory.
@busser busser mentioned this issue Feb 26, 2024
Merged
busser added a commit that referenced this issue Feb 26, 2024
@busser
🐛 Respect --terraform-bin flag in output (#83)
b02dc41 
Fixes #70.

Adds end-to-end tests for the different output formats.

Removes an extra space from generated commands when the target workspace
is the current working directory.
@busser busser reopened this Feb 26, 2024
@busser
Copy link
Owner

busser commented Feb 26, 2024 •
edited
Loading

This is fixed in v0.6.2 🙂. Thanks again for reporting this bug!

@busser busser closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Respect --terraform-bin flag in output busser/tfautomv
3 participants
@strowi @p1gmale0n @busser