Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for defining metrics #819

Merged
merged 3 commits into from
Jul 24, 2021
Merged

add support for defining metrics #819

merged 3 commits into from
Jul 24, 2021

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

…ne arbitrary metrics

names that get captured in test result. We can capture metrics based on regular expression
on stdout, stderr. Metrics can be captured via environment variables or variables. This works
with script and compiler schema.
content of output and error content from file.
Add method post_run_steps to BuilderBase which is called by all executors after running
tests which will copy stage files, and calculate test state (PASS/FAIL).
Moved method implementation for check_test_state, _check_regex, _returncode_check, _check_runtime to BuilderBase
class and remove the method implementation from BaseExecutor class
Update example buildspec for metrics with compiler schema example
@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #819 (5d8309d) into devel (0f4b264) will decrease coverage by 5.02%.
The diff coverage is 58.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #819      +/-   ##
==========================================
- Coverage   79.60%   74.58%   -5.02%     
==========================================
  Files          37       37              
  Lines        4249     4276      +27     
  Branches      789      800      +11     
==========================================
- Hits         3382     3189     -193     
- Misses        687      904     +217     
- Partials      180      183       +3     
Impacted Files Coverage Δ
buildtest/cli/build.py 87.59% <ø> (-0.55%) ⬇️
buildtest/executors/base.py 100.00% <ø> (+27.27%) ⬆️
buildtest/executors/cobalt.py 24.46% <0.00%> (-8.16%) ⬇️
buildtest/executors/lsf.py 21.43% <0.00%> (-61.21%) ⬇️
buildtest/executors/pbs.py 28.70% <0.00%> (+0.13%) ⬆️
buildtest/cli/report.py 89.86% <14.29%> (-2.56%) ⬇️
buildtest/buildsystem/base.py 80.27% <61.00%> (-12.03%) ⬇️
buildtest/executors/local.py 89.13% <100.00%> (-0.67%) ⬇️
buildtest/executors/slurm.py 79.71% <100.00%> (-0.57%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4b264...5d8309d. Read the comment docs.

@shahzebsiddiqui shahzebsiddiqui merged commit 6c47424 into devel Jul 24, 2021
@shahzebsiddiqui shahzebsiddiqui deleted the metric_property branch July 24, 2021 04:51
@shahzebsiddiqui shahzebsiddiqui linked an issue Jul 24, 2021 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics property
1 participant