Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spack buildsystem #774

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Add support for spack buildsystem #774

merged 4 commits into from
Jun 29, 2021

Conversation

shahzebsiddiqui
Copy link
Member

This PR will add spack-v1.0.schema.json which will support type: spack so one can write test using this schema. In addition, we have provided a few examples using the spack schema along with user documentation

… invalid examples.

add test_spack.py script to run the regression test for the schema
using the spack buildsystem that is defined using 'type: spack' in the buildspecs.
There are 5 example buildspecs that outline how one can do the following
1. Install specs using spack
2. Install specs in spack environment and create and activate spack environment
3. Create a spack environment as a directory and concretize specs
4. Add pre and post commands to run arbitrary linux commands before and after spack commands
…roperty.

Define method _default_test_variables in BuilderBase that declares variables
set in each test.
Update spack documentation page with examples
@shahzebsiddiqui shahzebsiddiqui linked an issue Jun 29, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #774 (fc8e41c) into devel (77dd5ab) will decrease coverage by 4.48%.
The diff coverage is 70.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #774      +/-   ##
==========================================
- Coverage   79.95%   75.47%   -4.48%     
==========================================
  Files          35       36       +1     
  Lines        3836     3987     +151     
  Branches      683      712      +29     
==========================================
- Hits         3067     3009      -58     
- Misses        600      797     +197     
- Partials      169      181      +12     
Impacted Files Coverage Δ
buildtest/buildsystem/batch.py 54.37% <14.29%> (-16.30%) ⬇️
buildtest/cli/build.py 85.74% <71.43%> (-4.69%) ⬇️
buildtest/buildsystem/spack.py 78.65% <78.65%> (ø)
buildtest/buildsystem/builders.py 86.92% <80.00%> (+0.52%) ⬆️
buildtest/buildsystem/base.py 81.65% <100.00%> (-4.64%) ⬇️
buildtest/buildsystem/parser.py 93.55% <100.00%> (ø)
buildtest/schemas/defaults.py 100.00% <100.00%> (ø)
buildtest/utils/file.py 86.81% <100.00%> (-0.28%) ⬇️
buildtest/executors/slurm.py 23.94% <0.00%> (-49.30%) ⬇️
buildtest/system.py 59.04% <0.00%> (-18.67%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77dd5ab...fc8e41c. Read the comment docs.

@shahzebsiddiqui shahzebsiddiqui merged commit cb10238 into devel Jun 29, 2021
@shahzebsiddiqui shahzebsiddiqui deleted the spack_buildsystem branch June 29, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spack buildsystem
1 participant