Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'runtime' property in status to check for test state #736

Merged
merged 5 commits into from
Apr 25, 2021
Merged

add 'runtime' property in status to check for test state #736

merged 5 commits into from
Apr 25, 2021

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

@shahzebsiddiqui
We reimplement how buildtest finds where to write logfiles. We moved …
e9cb012 
…implementation

to class BuildTest and we find path early in stage so we can record path in
each builder object. This can be useful if one wants to retrieve logfile from a particular test.
@shahzebsiddiqui
add runtime property in 'status' to check if test can pass based on r…
5348a13 
…untime results. One

can specify a 'min' and 'max' time.
Update schema and invalid and valid examples.
Add example test using the runtime property.
This fix #735
@codecov
Copy link

codecov bot commented Apr 23, 2021 •
edited
Loading

Codecov Report

Merging #736 (a7c39f0) into devel (d6abe81) will decrease coverage by 4.36%.
The diff coverage is 90.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #736      +/-   ##
==========================================
- Coverage   79.18%   74.82%   -4.36%     
==========================================
  Files          33       33              
  Lines        3569     3598      +29     
  Branches      670      676       +6     
==========================================
- Hits         2826     2692     -134     
- Misses        577      739     +162     
- Partials      166      167       +1
Impacted Files Coverage Δ
buildtest/buildsystem/base.py 76.34% <ø> (-6.45%) ⬇️
buildtest/cli/report.py 94.42% <ø> (ø)
buildtest/cli/build.py 84.20% <71.43%> (-2.75%) ⬇️
buildtest/executors/base.py 90.67% <93.75%> (+0.50%) ⬆️
buildtest/log.py 100.00% <100.00%> (+36.84%) ⬆️
buildtest/executors/slurm.py 15.45% <0.00%> (-68.18%) ⬇️
buildtest/utils/timer.py 53.33% <0.00%> (-20.00%) ⬇️
buildtest/system.py 59.04% <0.00%> (-18.67%) ⬇️
buildtest/executors/setup.py 50.98% <0.00%> (-10.78%) ⬇️
buildtest/config.py 59.48% <0.00%> (-9.15%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6abe81...a7c39f0. Read the comment docs.

@shahzebsiddiqui
change moduletools property to N/A in cdash invalid settings example …
a7c39f0 
…because

these will be running on github infrastructure which doesn't have a module tool
installed. We were facing an error in CI check
@shahzebsiddiqui shahzebsiddiqui merged commit d2f83b2 into devel Apr 25, 2021
@shahzebsiddiqui shahzebsiddiqui deleted the runtime branch April 25, 2021 16:05
@shahzebsiddiqui shahzebsiddiqui linked an issue Apr 25, 2021 that may be closed by this pull request
pass condition based on runtime #735
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pass condition based on runtime
1 participant
@shahzebsiddiqui