add olcf regression test for ascent system to get test coverage for LSF #663

shahzebsiddiqui · 2021-02-25T20:30:17Z

No description provided.

There was bug where buildtest couldn't resolve path to generated output because we were using wrong directory to submit job. We should submit jobs from stage directory so the generated files are in the same location as the job script. hardcode python module version when running olcf pipeline, that way if system python changes we dont break workflow

codecov · 2021-02-25T20:31:09Z

Codecov Report

Merging #663 (f929a71) into devel (dbddad0) will increase coverage by 6.96%.
The diff coverage is 60.91%.

@@            Coverage Diff             @@
##            devel     #663      +/-   ##
==========================================
+ Coverage   57.69%   64.66%   +6.96%     
==========================================
  Files          21       34      +13     
  Lines        1553     2804    +1251     
  Branches      226      513     +287     
==========================================
+ Hits          896     1813     +917     
- Misses        606      867     +261     
- Partials       51      124      +73

Impacted Files	Coverage Δ
buildtest/log.py	`63.16% <ø> (ø)`
buildtest/executors/slurm.py	`13.95% <13.95%> (ø)`
buildtest/executors/cobalt.py	`15.52% <15.52%> (ø)`
buildtest/executors/lsf.py	`16.22% <16.22%> (ø)`
buildtest/buildsystem/compilerbuilder.py	`24.35% <24.35%> (ø)`
buildtest/menu/__init__.py	`44.44% <34.78%> (+23.75%)`	⬆️
buildtest/config.py	`37.80% <35.44%> (-62.20%)`	⬇️
buildtest/menu/compilers.py	`37.96% <37.96%> (ø)`
buildtest/executors/setup.py	`43.82% <43.82%> (ø)`
buildtest/docs.py	`60.00% <60.00%> (ø)`
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 811469c...5784f73. Read the comment docs.

shahzebsiddiqui added 2 commits February 25, 2021 12:50

add ascent regression test example to submit job to LSF cluster

fb9dcf7

pull-request-size bot added the size/M label Feb 25, 2021

shahzebsiddiqui merged commit 69e4ce6 into devel Feb 25, 2021

shahzebsiddiqui deleted the olcf_regtest branch February 25, 2021 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add olcf regression test for ascent system to get test coverage for LSF #663

add olcf regression test for ascent system to get test coverage for LSF #663

shahzebsiddiqui commented Feb 25, 2021

codecov bot commented Feb 25, 2021 •

edited

Loading

add olcf regression test for ascent system to get test coverage for LSF #663

add olcf regression test for ascent system to get test coverage for LSF #663

Conversation

shahzebsiddiqui commented Feb 25, 2021

codecov bot commented Feb 25, 2021 • edited Loading

Codecov Report

codecov bot commented Feb 25, 2021 •

edited

Loading