Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_pend_time implementation for LSF #510

Merged
merged 2 commits into from
Oct 16, 2020
Merged

max_pend_time implementation for LSF #510

merged 2 commits into from
Oct 16, 2020

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

@shahzebsiddiqui
initial attempt to implement max_pend_time configuration for LSF
e38da94
@shahzebsiddiqui
test functionality of max_pend_time in LSF cluster. We successfully t…
0b42af5 
…ested

one job cancelled once it reached max_pend_time via bkill.
There was an issue installating buildtest in tcsh/csh which was fixed
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #510 into devel will increase coverage by 13.02%.
The diff coverage is 66.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##            devel     #510       +/-   ##
===========================================
+ Coverage   57.69%   70.72%   +13.02%     
===========================================
  Files          21       23        +2     
  Lines        1553     1933      +380     
  Branches      226      342      +116     
===========================================
+ Hits          896     1367      +471     
+ Misses        606      477      -129     
- Partials       51       89       +38
Impacted Files Coverage Δ
buildtest/log.py 63.16% <ø> (ø)
buildtest/executors/lsf.py 16.95% <16.95%> (ø)
buildtest/executors/slurm.py 19.20% <19.20%> (ø)
buildtest/executors/setup.py 52.63% <52.63%> (ø)
buildtest/docs.py 60.00% <60.00%> (ø)
buildtest/menu/schema.py 58.00% <67.86%> (-30.89%) ⬇️
buildtest/menu/build.py 69.20% <71.05%> (+43.58%) ⬆️
buildtest/utils/file.py 94.29% <75.00%> (-2.77%) ⬇️
buildtest/menu/buildspec.py 77.67% <77.44%> (+18.45%) ⬆️
buildtest/system.py 66.67% <77.78%> (+42.05%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc00eff...0b42af5. Read the comment docs.

@shahzebsiddiqui shahzebsiddiqui merged commit 5ab4cd6 into buildtesters:devel Oct 16, 2020
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 16, 2020
@shahzebsiddiqui shahzebsiddiqui linked an issue Oct 19, 2020 that may be closed by this pull request
cancel job after some interval #505
Closed
@shahzebsiddiqui shahzebsiddiqui deleted the max_pendtime_lsf branch November 12, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cancel job after some interval
1 participant
@shahzebsiddiqui