Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option --validate in buildtest schema. Change behavior of buildtest schema --examples #502

Merged

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

…les to now

only show schema examples previously we validated the examples. Now these options
are separated.
There were few bugs in schema examples which needed to be fixed. They were related
to invalid executor name.
Modified the regression test for "buildtest schema" command in order to add coverage
for new option.
Add page for Buildspec Schema Examples that shows schema file and examples for
all schemas except settings.schema.json
Add commands in docgen.py to automate buildtest schema commands
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #502 into devel will increase coverage by 0.31%.
The diff coverage is 54.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #502      +/-   ##
==========================================
+ Coverage   72.42%   72.74%   +0.31%     
==========================================
  Files          27       27              
  Lines        1882     1889       +7     
  Branches      323      328       +5     
==========================================
+ Hits         1363     1374      +11     
+ Misses        432      424       -8     
- Partials       87       91       +4     
Impacted Files Coverage Δ
buildtest/buildsystem/parser.py 75.53% <0.00%> (-1.64%) ⬇️
buildtest/menu/__init__.py 40.00% <ø> (ø)
buildtest/menu/schema.py 58.00% <60.00%> (+17.57%) ⬆️
buildtest/menu/buildspec.py 77.21% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a60d6...0a8000a. Read the comment docs.

@shahzebsiddiqui shahzebsiddiqui merged commit fdd1f28 into buildtesters:devel Oct 2, 2020
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Oct 2, 2020
@shahzebsiddiqui shahzebsiddiqui deleted the schema_example_change branch October 2, 2020 21:45
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant