Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More batch keys #494

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

Sort keys alphabetically in schema and update docs
…finition.

Set additionalProperties:false on batch field to avoid extra key=value pairs.
Add example tests for testing in schema
Add regression tests for LSFBatchScript and SlurmBatchScript class to test few
examples and increase test coverage for class
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #494 into devel will increase coverage by 1.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #494      +/-   ##
==========================================
+ Coverage   71.31%   72.39%   +1.08%     
==========================================
  Files          27       23       -4     
  Lines        1875     1807      -68     
  Branches      320      313       -7     
==========================================
- Hits         1337     1308      -29     
+ Misses        456      415      -41     
- Partials       82       84       +2     
Impacted Files Coverage Δ
buildtest/buildsystem/batch.py 80.49% <50.00%> (+53.46%) ⬆️
buildtest/defaults.py
buildtest/config.py
buildtest/__init__.py
buildtest/menu/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c75c1...452c90e. Read the comment docs.

@shahzebsiddiqui shahzebsiddiqui merged commit 8189c1f into buildtesters:devel Sep 28, 2020
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 28, 2020
@shahzebsiddiqui shahzebsiddiqui deleted the more_batch_keys branch September 30, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant